Re: [PATCH v2] kbuild: Change fallthrough comments to attributes

From: Joe Perches
Date: Tue Aug 13 2019 - 03:43:19 EST


On Tue, 2019-08-13 at 00:04 -0700, Joe Perches wrote:
> On Mon, 2019-08-12 at 23:33 -0700, Nathan Chancellor wrote:
[]
> > a disagreement between GCC and Clang on
> > emitting a warning when falling through to a case statement that is
> > either the last one and empty or simply breaks..
[]
> > I personally think that GCC is right and Clang should adapt but I don't
> > know enough about the Clang codebase to know how feasible this is.
>
> I think gcc is wrong here and code like
>
> switch (foo) {
> case 1:
> bar = 1;
> default:
> break;
> }
>
> should emit a fallthrough warning.

btw: I just filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91432