Re: [PATCH v2 4/4] i2c/busses/i2c-icy: Add platform_data for LTC2990

From: Geert Uytterhoeven
Date: Tue Aug 13 2019 - 03:04:34 EST


Hi Max,

On Tue, Aug 13, 2019 at 1:54 AM Max Staudt <max@xxxxxxxxx> wrote:
> This enables the three additional inputs available on the 2019 a1k.org
> reprint of the ICY board:
>
> in1 will be the voltage of the 5V rail, divided by 2.
> in2 will be the voltage of the 12V rail, divided by 4.
> temp3 will be measured using a PCB loop next the chip.
>
> Signed-off-by: Max Staudt <max@xxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

However, I would merge patches 2/4 and 4/4, and move the result
after patch 3.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds