Re: [v4 4/6] dt-bindings: phy: Document the Synopsys MIPI DPHY Rx bindings

From: Sakari Ailus
Date: Fri Aug 09 2019 - 10:45:33 EST


On Fri, Aug 09, 2019 at 05:42:52PM +0300, Sakari Ailus wrote:
> Hi Luis,
>
> On Tue, Jun 11, 2019 at 09:20:53PM +0200, Luis Oliveira wrote:
> > Add device-tree bindings documentation for SNPS DesignWare MIPI D-PHY in
> > RX mode.
> >
> > Signed-off-by: Luis Oliveira <luis.oliveira@xxxxxxxxxxxx>
> > ---
> > Changelog
> > v3-v4
> > - @Laurent I know I told you I could remove the snps,dphy-frequency on V3 but
> > it is really useful for me here. I removed all other the proprietary
> > properties except this one. Do you still think it must be removed?
>
> Yes. DT is the wrong place for runtime configuration. You get that
> information using the V4L2_CID_LINK_FREQ control on the upstream
> sub-device.

And the PHY driver itself gets that in its configuration (struct
phy_configure_opts_mipi_dphy through the configure op).

--
Sakari Ailus