Re: [PATCH v2 13/15] net: phy: adin: configure downshift on config_init

[Ardelean, Alexandru]

On Thu, 2019-08-08 at 22:39 +0200, Andrew Lunn wrote:
> [External]
> 
> On Thu, Aug 08, 2019 at 09:38:40PM +0200, Heiner Kallweit wrote:
> > On 08.08.2019 14:30, Alexandru Ardelean wrote:
> > > Down-speed auto-negotiation may not always be enabled, in which case the
> > > PHY won't down-shift to 100 or 10 during auto-negotiation.
> > > 
> > > This change enables downshift and configures the number of retries to
> > > default 8 (maximum supported value).
> > > 
> > > The change has been adapted from the Marvell PHY driver.
> > > 
> > Instead of a fixed downshift setting (like in the Marvell driver) you
> > may consider to implement the ethtool phy-tunable ETHTOOL_PHY_DOWNSHIFT.
> 
> Hi Alexandru
> 
> Upps, sorry, my bad.
> 
> I looked at marvell_set_downshift(), and assumed it was connected to
> the phy-tunable. I have patches somewhere which does that. But they
> have not made it into mainline yet.
> 
> > See the Aquantia PHY driver for an example.
> 
> Yes, that does have all the tunable stuff.

Ack.
Will use that

> 
>      Andrew