Re: [PATCH v2 1/2] drivers/ras: Don't build debugfs.o if no debugfs in config

From: Borislav Petkov
Date: Thu Aug 08 2019 - 10:20:14 EST


On Thu, Aug 08, 2019 at 09:01:39AM -0400, Valdis KlÄtnieks wrote:
> It's needed if somebody applies the patch 2/2 -

It is needed for what?

> and I just got a note from the kbuild test robot saying that
> happened....

Yes, I don't see any issues with 2/2 only applied. I could be missing
some aspect though...

> And if it's that useless, maybe *more* needs to be done to ensure that
> debugfs is enabled if ras is being built - possibly a Kconfig 'select'
> or something....

Or something:

config RAS_CEC
depends on X86_MCE && MEMORY_FAILURE && DEBUG_FS
^^^^^^^^
--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.