Re: [PATCH] regulator: stm32-booster: Remove .min_uV and .list_voltage for fixed regulator

From: Fabrice Gasnier
Date: Tue Jul 23 2019 - 04:08:46 EST


On 7/23/19 3:41 AM, Axel Lin wrote:
> Setting .n_voltages = 1 and .fixed_uV is enough for fixed regulator,
> remove the redundant .min_uV and .list_voltage settings.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>

Hi Axel,

Acked-by: Fabrice Gasnier <fabrice.gasnier@xxxxxx>

Thanks,
Fabrice
> ---
> drivers/regulator/stm32-booster.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/regulator/stm32-booster.c b/drivers/regulator/stm32-booster.c
> index 2a897666c650..03f162ffd144 100644
> --- a/drivers/regulator/stm32-booster.c
> +++ b/drivers/regulator/stm32-booster.c
> @@ -20,7 +20,6 @@
> #define STM32MP1_SYSCFG_EN_BOOSTER_MASK BIT(8)
>
> static const struct regulator_ops stm32h7_booster_ops = {
> - .list_voltage = regulator_list_voltage_linear,
> .enable = regulator_enable_regmap,
> .disable = regulator_disable_regmap,
> .is_enabled = regulator_is_enabled_regmap,
> @@ -31,7 +30,6 @@ static const struct regulator_desc stm32h7_booster_desc = {
> .supply_name = "vdda",
> .n_voltages = 1,
> .type = REGULATOR_VOLTAGE,
> - .min_uV = 3300000,
> .fixed_uV = 3300000,
> .ramp_delay = 66000, /* up to 50us to stabilize */
> .ops = &stm32h7_booster_ops,
> @@ -53,7 +51,6 @@ static int stm32mp1_booster_disable(struct regulator_dev *rdev)
> }
>
> static const struct regulator_ops stm32mp1_booster_ops = {
> - .list_voltage = regulator_list_voltage_linear,
> .enable = stm32mp1_booster_enable,
> .disable = stm32mp1_booster_disable,
> .is_enabled = regulator_is_enabled_regmap,
> @@ -64,7 +61,6 @@ static const struct regulator_desc stm32mp1_booster_desc = {
> .supply_name = "vdda",
> .n_voltages = 1,
> .type = REGULATOR_VOLTAGE,
> - .min_uV = 3300000,
> .fixed_uV = 3300000,
> .ramp_delay = 66000,
> .ops = &stm32mp1_booster_ops,
>