Re: [PATCH 06/10] ASoC: dt-bindings: Document dl_mask property

[Lucas Stach]

Am Montag, den 22.07.2019, 15:48 +0300 schrieb Daniel Baluta:
> SAI supports up to 8 data lines. This property let the user
> configure how many data lines should be used per transfer
> direction (Tx/Rx).
> 
> > Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx>
> ---
> ÂDocumentation/devicetree/bindings/sound/fsl-sai.txt | 5 +++++
> Â1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> index 2e726b983845..59f4d965a5fb 100644
> --- a/Documentation/devicetree/bindings/sound/fsl-sai.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> @@ -49,6 +49,11 @@ Optional properties:
> Â
> > ÂÂÂ- big-endian		: Boolean property, required if all the SAI
> > Â			ÂÂregisters are big-endian rather than little-endian.
> > +ÂÂ- fsl,dl_mask		: list of two integers (bitmask, first for RX, second
> > +			ÂÂfor TX) representing enabled datalines. Bit 0
> > +			ÂÂrepresents first data line, bit 1 represents second
> > +			ÂÂdata line and so on. Data line is enabled if
> > +			ÂÂcorresponding bit is set to 1.

No underscores in property names, please. Also this should document the
default value used by the driver when the property is absent.

Regards,
Lucas