[PATCH] fs/omfs: make use of kmemdup
From: Hariprasad Kelam
Date: Sun Jul 21 2019 - 07:23:41 EST
kmalloc + memcpy can be replaced with kmemdup.
fix below issue reported by coccicheck
./fs/omfs/inode.c:366:9-16: WARNING opportunity for kmemdup
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@xxxxxxxxx>
---
fs/omfs/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index 08226a8..bc5a072 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb)
bh = sb_bread(sb, block++);
if (!bh)
goto nomem_free;
- *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
+ *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
if (!*ptr) {
brelse(bh);
goto nomem_free;
}
- memcpy(*ptr, bh->b_data, sb->s_blocksize);
if (count < sb->s_blocksize)
memset((void *)*ptr + count, 0xff,
sb->s_blocksize - count);
--
2.7.4