Re: [PATCH v3 3/9] x86/mm/tlb: Open-code on_each_cpu_cond_mask() for tlb_is_not_lazy()

From: Dave Hansen
Date: Fri Jul 19 2019 - 14:36:52 EST


On 7/18/19 5:58 PM, Nadav Amit wrote:
> @@ -865,7 +893,7 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch)
> if (cpumask_test_cpu(cpu, &batch->cpumask)) {
> lockdep_assert_irqs_enabled();
> local_irq_disable();
> - flush_tlb_func_local(&full_flush_tlb_info);
> + flush_tlb_func_local((void *)&full_flush_tlb_info);
> local_irq_enable();
> }

This looks like superfluous churn. Is it?