Re: [PATCH] mac80211: don't warn about CW params when not using them

From: Brian Norris
Date: Thu Jul 18 2019 - 11:48:40 EST


On Thu, Jul 18, 2019 at 12:45 AM Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote:
> Fix looks fine for me. However I think rtw88 should implement
> drv_conf_tx() because parameters can be different on different
> network setups and maybe more important WMM/AC parameters become
> quite recently part of ETSI regulatory.

Ack. I just figured we should stay consistent with the WARNINGs (and
we both noticed this one on earlier patch reviews). I don't know about
you, but for me, the whole wireless stack is so full of WARNINGs that
my crash reporter system separately classifies net/wireless and
drivers/net/wireless/ from the rest of the kernel when categorizing
automated problem reports. (And...most developers then ignore them.)

But I digress ;)

Brian