Re: [PATCH V3 00/15] Packed virtqueue support for vhost

From: Michael S. Tsirkin
Date: Wed Jul 17 2019 - 10:28:54 EST


On Wed, Jul 17, 2019 at 08:27:28PM +0800, Jason Wang wrote:
>
> On 2019/7/17 äå7:02, Michael S. Tsirkin wrote:
> > On Wed, Jul 17, 2019 at 06:52:40AM -0400, Jason Wang wrote:
> > > Hi all:
> > >
> > > This series implements packed virtqueues which were described
> > > at [1]. In this version we try to address the performance regression
> > > saw by V2. The root cause is packed virtqueue need more times of
> > > userspace memory accesssing which turns out to be very
> > > expensive. Thanks to the help of 7f466032dc9e ("vhost: access vq
> > > metadata through kernel virtual address"), such overhead cold be
> > > eliminated. So in this version, we can see about 2% improvement for
> > > packed virtqueue on PPS.
> > Great job, thanks!
> > Pls allow a bit more review time than usual as this is a big patchset.
> > Should be done by Tuesday.
> > -next material anyway.
>
>
> Sure, just to confirm, I think this should go for your vhost tree?.
>
> Thanks

I think this makes sense, yes.