Re: [PATCH V2] mpt3sas: support target smid for [abort|query] task

From: Minwoo Im
Date: Wed Jul 17 2019 - 08:12:09 EST


On 19-07-15 08:13:36, Hannes Reinecke wrote:
> I think this is fundamentally wrong.
> ABORT_TASK is used to abort a single task, which of course has to be
> known beforehand. If you don't know the task, what exactly do you hope
> to achieve here? Aborting random I/O?
> Or, even worse, aborting I/O the driver uses internally and corrupt the
> internal workflow of the driver?
>
> We should simply disallow any ABORT TASK from userspace if the TaskMID
> is zero. And I would even argue to disabllow ABORT TASK from userspace
> completely, as the smid is never relayed to userland, and as such the
> user cannot know which task should be aborted.
>
> Cheers,
>
> Hannes

Sreekanth,

Could you please give some thoughts about what Hannes said?