Re: [PATCH v2 2/3] nvme-pci: Add support for variable IO SQ element size

From: Benjamin Herrenschmidt
Date: Wed Jul 17 2019 - 08:02:58 EST


On Wed, 2019-07-17 at 20:51 +0900, Minwoo Im wrote:
> - struct nvme_command *sq_cmds;
> > + void *sq_cmds;
>
> It would be great if it can remain the existing data type for the
> SQEs... But I'm fine with this also.
>
> It looks good to me.

I changed it on purpose so we aren't tempted to index the array, since
that's not always valid.

Cheers,
Ben.