Re: [PATCH 2/2] Fixed a brace styling issue

From: Marcel Holtmann
Date: Thu Jul 11 2019 - 03:03:47 EST


Hi,

> Fixed a coding style issue
>
> Signed-off-by: Sheetal Singala <2396sheetal@xxxxxxxxx>
> ---
> drivers/bluetooth/btintel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index bb99c8653aab..4a8b812605f3 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -18,7 +18,7 @@
>
> #define VERSION "0.1"
>
> -#define BDADDR_INTEL (&(bdaddr_t) {{0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00}})
> +#define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})

maybe you want to test your patches before sending them.

CC drivers/bluetooth/btintel.o
drivers/bluetooth/btintel.c: In function âbtintel_check_bdaddrâ:
drivers/bluetooth/btintel.c:21:24: warning: missing braces around initializer [-Wmissing-braces]
21 | #define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})
| ^
drivers/bluetooth/btintel.c:50:27: note: in expansion of macro âBDADDR_INTELâ
50 | if (!bacmp(&bda->bdaddr, BDADDR_INTEL)) {
| ^~~~~~~~~~~~

Regards

Marcel