Re: [GIT PULL] x86/topology changes for v5.3

From: Kees Cook
Date: Wed Jul 10 2019 - 01:33:23 EST


On Tue, Jul 09, 2019 at 10:15:21PM -0700, Linus Torvalds wrote:
> On Tue, Jul 9, 2019 at 8:21 PM Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Whee. It looks like it's bisecting to the same thing. Only partway
> > done, but it feels very much like my desktop.
>
> Confirmed.
>
> With that config, I get this
>
> c21ac93288f0 (refs/bisect/bad) Merge tag 'v5.2-rc6' into x86/asm, to
> refresh the branch
> 8dbec27a242c (HEAD) x86/asm: Pin sensitive CR0 bits
> 873d50d58f67 x86/asm: Pin sensitive CR4 bits
>
> ie those "pin sensitive bits" merge is bad, but before the commits is good.
>
> I think there is _another_ problem too, and maybe it's the APCI one,
> but this one triggers some issue before the other issue even gets to
> play..

Okay, fun. Thanks for confirming it. Well, I guess I get to try to
find some more modern hardware to track this down. Does booting with
init=/bin/sh get far enough to see if all the CPUs are online or anything
like that? I'm baffled about the "gets mostly to userspace" part. I'd
expect this to explode very badly if it misbehaved. Or maybe something
gets confused between how many CPUs are expected and how many actually
show up to the party. Hmmm.

--
Kees Cook