Re: [PATCH v2] kbuild: get rid of misleading $(AS) from documents

From: Masahiro Yamada
Date: Mon Jul 08 2019 - 21:07:57 EST


On Tue, Jul 9, 2019 at 5:02 AM Jonathan Corbet <corbet@xxxxxxx> wrote:
>
> On Sun, 7 Jul 2019 01:25:08 +0900
> Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>
> > The assembler files in the kernel are *.S instead of *.s, so they must
> > be preprocessed. Since 'as' of GNU binutils is not able to preprocess,
> > we always use $(CC) as an assembler driver.
> >
> > $(AS) is almost unused in Kbuild. As of writing, there is just one place
> > that directly invokes $(AS).
> >
> > $ git grep -e '$(AS)' -e '${AS}' -e '$AS' -e '$(AS:' -e '${AS:' -- :^Documentation
> > drivers/net/wan/Makefile: AS68K = $(AS)
> >
> > The documentation about *_AFLAGS* sounds like the flags were passed
> > to $(AS). This is somewhat misleading.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > Reviewed-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
>
> Would you like me to send this up through the docs tree?

No, I will apply it to linux-kbuild shortly.

Thanks.


--
Best Regards
Masahiro Yamada