Re: [PATCH] Bluetooth: hci_ldisc: check for missing tty operations

[Vladis Dronov]

Hello, Marcel,

I totally agree, the same came to my mind some time after sending the patch.
Let me send a v2 in a while with drivers checking for needed tty operations
presence.

Best regards,
Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer

----- Original Message -----
> From: "Marcel Holtmann" <marcel@xxxxxxxxxxxx>
> To: "Vladis Dronov" <vdronov@xxxxxxxxxx>
> Cc: "Johan Hedberg" <johan.hedberg@xxxxxxxxx>, linux-bluetooth@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
> syzbot+79337b501d6aa974d0f6@xxxxxxxxxxxxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, "Loic Poulain"
> <loic.poulain@xxxxxxxxx>, "Ilya Faenson" <ifaenson@xxxxxxxxxxxx>
> Sent: Saturday, July 6, 2019 12:35:39 PM
> Subject: Re: [PATCH] Bluetooth: hci_ldisc: check for missing tty operations
> 
> Hi Vladis,
> 
> > Certain ttys lack operations (eg: pty_unix98_ops) which still can be
> > called by certain hci uart proto (eg: mrvl, ath). Currently this leads
> > to execution at address 0x0. Fix this by adding checks for missing tty
> > operations.
> 
> so I really prefer that we just fail setting the line discipline. These
> drivers need to check that the underlying transport has all the operations
> available they need. We can not just ignore them.
> 
> Regards
> 
> Marcel