Re: [PATCH] staging: speakup: One function call less in speakup_win_enable()

From: Greg Kroah-Hartman
Date: Sat Jul 06 2019 - 05:29:21 EST


On Sat, Jul 06, 2019 at 11:00:19AM +0200, Samuel Thibault wrote:
> Markus Elfring, le sam. 06 juil. 2019 10:15:30 +0200, a ecrit:
> > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > Date: Sat, 6 Jul 2019 10:03:56 +0200
> >
> > Avoid an extra function call by using a ternary operator instead of
> > a conditional statement.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

Sorry, but this author/bot is in my kill-file and I no longer accept
patches from them.

And I HATE ternary operators anyway, so it's not like I would take this
patch if it came from someone else :)

thanks,

greg k-h