Re: [PATCH v2 1/7] x86/paravirt: Make read_cr2() CALLEE_SAVE

From: Andy Lutomirski
Date: Thu Jul 04 2019 - 17:49:47 EST


On Thu, Jul 4, 2019 at 1:03 PM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> The one paravirt read_cr2() implementation (Xen) is actually quite
> trivial and doesn't need to clobber anything other than the return
> register. By making read_cr2() CALLEE_SAVE we avoid all the PUSH/POP
> nonsense and allow more convenient use from assembly.

Wow, this is incomprehensible! :) I'll trust Juergen's review.

--Andy