Re: [PATCH v6 07/18] drm/virtio: add virtio_gpu_object_array & helpers

From: Gerd Hoffmann
Date: Thu Jul 04 2019 - 07:19:59 EST


> > > +int virtio_gpu_array_lock_resv(struct virtio_gpu_object_array *objs)
> > > +{
> > > + return drm_gem_lock_reservations(objs->objs, objs->nents,
> > > + &objs->ticket);
> Unlike in other drivers where an "object array" is only needed in
> execbuffer, we will use this in several places, and often with only 1
> object in the array. Can we special case that and do a quick
> reservation_object_lock?

Yes, done.

> > > +void virtio_gpu_array_unlock_resv(struct virtio_gpu_object_array *objs)
> > > +{
> > > + drm_gem_unlock_reservations(objs->objs, objs->nents,
> > > + &objs->ticket);
> > > +}
> > > +

Likewise here.

cheers,
Gerd