Re: [PATCH] crypto: cryptd - Fix skcipher instance memory leak

From: Herbert Xu
Date: Wed Jul 03 2019 - 10:29:59 EST


Vincent Whitchurch <vincent.whitchurch@xxxxxxxx> wrote:
> cryptd_skcipher_free() fails to free the struct skcipher_instance
> allocated in cryptd_create_skcipher(), leading to a memory leak. This
> is detected by kmemleak on bootup on ARM64 platforms:
>
> unreferenced object 0xffff80003377b180 (size 1024):
> comm "cryptomgr_probe", pid 822, jiffies 4294894830 (age 52.760s)
> backtrace:
> kmem_cache_alloc_trace+0x270/0x2d0
> cryptd_create+0x990/0x124c
> cryptomgr_probe+0x5c/0x1e8
> kthread+0x258/0x318
> ret_from_fork+0x10/0x1c
>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>
> ---
> crypto/cryptd.c | 1 +
> 1 file changed, 1 insertion(+)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt