Re: [PATCH v4] mtd: spi-nor: fix nor->addr_width when its value configured from SFDP does not match the actual width

From: Tudor.Ambarus
Date: Fri Jun 28 2019 - 04:21:04 EST




On 06/27/2019 04:23 PM, Vignesh Raghavendra wrote:
> External E-Mail
>
>
>
> On 24/06/19 9:30 PM, Liu Xiang wrote:
>> IS25LP256 gets BFPT_DWORD1_ADDRESS_BYTES_3_ONLY from BFPT table for
>> address width. But in actual fact the flash can support 4-byte address.
>> Use a post bfpt fixup hook to overwrite the address width advertised by
>> the BFPT.
>>
>> Suggested-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>

dropped Suggested-by tag, you can't add this tag for each change request. You
should add it only when someone gives you the general idea on how to do the patch.

>> Signed-off-by: Liu Xiang <liu.xiang6@xxxxxxxxxx>
>>
>
> Reviewed-by: Vignesh Raghavendra <vigneshr@xxxxxx>
>
> Regards
> Vignesh
>
>> ---
>>
>> Changes in v4:
>> update the comment suggested by Tudor.
>> ---
>> drivers/mtd/spi-nor/spi-nor.c | 25 ++++++++++++++++++++++++-
>> 1 file changed, 24 insertions(+), 1 deletion(-)
>>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git,
spi-nor/next branch.

Thanks,
ta