Re: [PATCH v10 1/6] mfd: rk808: remove the id_table

From: Lee Jones
Date: Wed Jun 26 2019 - 07:54:05 EST


On Fri, 21 Jun 2019, Tony Xie wrote:

> Remove the id_table because it's not used.
>
> Signed-off-by: Tony Xie <tony.xie@xxxxxxxxxxxxxx>
> ---
> drivers/mfd/rk808.c | 9 ---------
> 1 file changed, 9 deletions(-)

Also, this patch already appears to be applied.

Once patches are taken from the set, you should avoid resending them.

> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index 216fbf6adec9..94377782d208 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -568,14 +568,6 @@ static int rk808_remove(struct i2c_client *client)
> return 0;
> }
>
> -static const struct i2c_device_id rk808_ids[] = {
> - { "rk805" },
> - { "rk808" },
> - { "rk818" },
> - { },
> -};
> -MODULE_DEVICE_TABLE(i2c, rk808_ids);
> -
> static struct i2c_driver rk808_i2c_driver = {
> .driver = {
> .name = "rk808",
> @@ -583,7 +575,6 @@ static struct i2c_driver rk808_i2c_driver = {
> },
> .probe = rk808_probe,
> .remove = rk808_remove,
> - .id_table = rk808_ids,
> };
>
> module_i2c_driver(rk808_i2c_driver);

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog