Re: [PATCH] drm/virtio: move drm_connector_update_edid_property() call

From: Gerd Hoffmann
Date: Wed Jun 26 2019 - 05:15:37 EST


On Wed, Jun 26, 2019 at 09:51:46AM +0200, Cornelia Huck wrote:
> On Fri, 5 Apr 2019 06:46:02 +0200
> Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
>
> > drm_connector_update_edid_property can sleep, we must not
> > call it while holding a spinlock. Move the callsize.
>
> s/callsize/callsite/

Fixed on commit.

> This gets rid of the sleeping while atomic traces I've been seeing with
> an s390x guest (both virtio-gpu-pci and virtio-gpu-ccw).
>
> Tested-by: Cornelia Huck <cohuck@xxxxxxxxxx>
>
> I have also looked at the code a bit, but don't feel confident enough
> to give an R-b.
>
> Acked-by: Cornelia Huck <cohuck@xxxxxxxxxx>

Thanks. Pushed to drm-misc-fixes.

cheers,
Gerd