Re: [PATCH 1/2] w1: add 1-wire master driver for IP block found in SGI ASICs

From: Thomas Bogendoerfer
Date: Tue Jun 25 2019 - 05:49:24 EST


On Fri, May 31, 2019 at 12:27:47PM +0200, Thomas Bogendoerfer wrote:
> Starting with SGI Origin machines nearly every new SGI ASIC contains
> an 1-Wire master. They are used for attaching One-Wire prom devices,
> which contain information about part numbers, revision numbers,
> serial number etc. and MAC addresses for ethernet interfaces.
> This patch adds a master driver to support this IP block.
> It also adds an extra field dev_id to struct w1_bus_master, which
> could be in used in slave drivers for creating unique device names.
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@xxxxxxx>
> ---
> drivers/w1/masters/Kconfig | 9 +++
> drivers/w1/masters/Makefile | 1 +
> drivers/w1/masters/sgi_w1.c | 130 +++++++++++++++++++++++++++++++++++
> include/linux/platform_data/sgi-w1.h | 15 ++++
> include/linux/w1.h | 2 +
> 5 files changed, 157 insertions(+)
> create mode 100644 drivers/w1/masters/sgi_w1.c
> create mode 100644 include/linux/platform_data/sgi-w1.h

Evgeniy,

are the patches ok for you or is there something to improve ? It would
be good, if they could get upstream during the next merge window, as
there are other patches from me depedning on them.

Thanks,
Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]