Re: [PATCH] riscv: dts: Re-organize SPI DT nodes

From: Anup Patel
Date: Mon Jun 24 2019 - 23:31:51 EST


On Tue, Jun 25, 2019 at 2:53 AM Paul Walmsley <paul.walmsley@xxxxxxxxxx> wrote:
>
> On Mon, 24 Jun 2019, Yash Shah wrote:
>
> > As per the General convention, define only device DT node in SOC DTSi
> > file with status = "disabled" and enable device in Board DTS file with
> > status = "okay"
> >
> > Reported-by: Anup Patel <anup@xxxxxxxxxxxxxx>
> > Signed-off-by: Yash Shah <yash.shah@xxxxxxxxxx>
>
> This is a good start, but should also cover the other I/O devices in the
> chip DT file. The mandatory internal devices, like the PRCI and PLIC, can
> stay the way they are.

Yes, this convention only applies to SoC devices with external connections
so PRCI, PLIC, and CLINT DT nodes are not required to follow this.

Eventually, this convention helps when we have multiple boards of same
SOC and each board having different set of peripherals connections.

Regards,
Anup