Re: [PATCH 04/15] ARM: exynos: cleanup cppcheck shifting error

From: Krzysztof Kozlowski
Date: Sun Jun 23 2019 - 15:13:09 EST


On Sun, 23 Jun 2019 at 17:14, Phong Tran <tranmanphong@xxxxxxxxx> wrote:
>
> [arch/arm/mach-exynos/suspend.c:288]: (error) Shifting signed 32-bit
> value by 31 bits is undefined behaviour
>
> Signed-off-by: Phong Tran <tranmanphong@xxxxxxxxx>
> ---
> arch/arm/mach-exynos/suspend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Let's switch to BIT macro. It will solve the problem and is preferred
way of coding.

Best regards,
Krzysztof