Re: [PATCH][next] lkdtm: remove redundant initialization of ret

From: Greg Kroah-Hartman
Date: Fri Jun 21 2019 - 09:50:12 EST


On Thu, Jun 20, 2019 at 11:13:32AM -0700, Kees Cook wrote:
> On Fri, Jun 14, 2019 at 10:43:11AM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > The variable ret is being initialized with the value -EINVAL however
> > this value is never read and ret is being re-assigned later on. Hence
> > the initialization is redundant and can be removed.
> >
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Thanks!
>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> Greg, can you take this please?

Will do, thanks.

greg k-h