Re: [PATCH] mtd: mtd-abi: Don't use C++ comments

From: Nick Desaulniers
Date: Thu Jun 20 2019 - 16:30:00 EST


On Thu, Jun 20, 2019 at 1:15 PM Nathan Chancellor
<natechancellor@xxxxxxxxx> wrote:
>
> On Thu, Jun 20, 2019 at 12:56:58PM -0700, Nick Desaulniers wrote:
> > Should there be a fixes by tag?
>
> Normally, I would have added one but this issue has been present since
> the beginning of git history. According to Thomas Gleixner's pre-git
> history tree, it would be:
>
> Fixes: 7df80b4c8964 ("MTD core include and device code cleanup")
>
> but since that hash doesn't exist in the normal git history, I don't
> think it is worth adding. Of course, if the maintainers want to add it,
> I won't object.
>
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git

LOL good point; I wonder if the stable maintainers have thoughts on
that or how they expect us to signal that case if we even need to do
anything at all.

Either way, thanks for the patch and
Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
--
Thanks,
~Nick Desaulniers