Re: [PATCH 2/2] coresight: Abort probe for missing CPU phandle

[Sai Prakash Ranjan]

Hi Mathieu,

Thanks for the review comments.

On 6/20/2019 11:13 PM, Mathieu Poirier wrote:
> On Thu, Jun 20, 2019 at 07:15:47PM +0530, Sai Prakash Ranjan wrote:
> > diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> > index 07a1367c733f..43f32fa71ff9 100644
> > --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> > +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> > @@ -579,6 +579,9 @@ static int debug_probe(struct amba_device *adev, const struct amba_id *id)
> >   		return -ENOMEM;
> >   
> >   	drvdata->cpu = coresight_get_cpu(dev);
> > +	if (drvdata->cpu == -ENODEV)
> > +		return -ENODEV;
>
> As Suzuki pointed out, simply return the error message conveyed by
> coresight_get_cpu().
>
> Also please merge both patches together to avoid bisect nightmare.

Sure, will do it.

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation