Re: [PATCH][bpf-next] bpf: verifier: add a break statement in switch

From: Gustavo A. R. Silva
Date: Wed Jun 19 2019 - 14:51:25 EST




On 6/19/19 12:44 PM, Andrii Nakryiko wrote:
> On Wed, Jun 19, 2019 at 9:07 AM Gustavo A. R. Silva
> <gustavo@xxxxxxxxxxxxxx> wrote:
>>
>> Notice that in this case, it's much clearer to explicitly add a break
>> rather than letting the code to fall through. It also avoid potential
>> future fall-through warnings[1].
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> [1] https://lore.kernel.org/patchwork/patch/1087056/
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>> ---
>
> Acked-by: Andrii Nakryiko <andriin@xxxxxx>
>

Thanks, Andrii.

--
Gustavo