Re: [PATCH] libnvdimm: Enable unit test infrastructure compile checks

From: Christoph Hellwig
Date: Wed Jun 19 2019 - 07:28:42 EST


On Mon, Jun 17, 2019 at 01:52:27PM -0700, Dan Williams wrote:
> The infrastructure to mock core libnvdimm routines for unit testing
> purposes is prone to bitrot relative to refactoring of that core.
> Arrange for the unit test core to be built when CONFIG_COMPILE_TEST=y.
> This does not result in a functional unit test environment, it is only a
> helper for 0day to catch unit test build regressions.

Looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

I'm still curious what the point of hiding kernel code in tools/
is vs fully integrating it with the build system.