Re: [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

From: Martin K. Petersen
Date: Tue Jun 18 2019 - 23:42:57 EST



Marcos,

> WWID composed from VPD data from device, specifically page 0x83. So,
> when a device does not have VPD support, for example USB storage
> devices where VPD is specifically disabled, a read into <blk
> device>/device/wwid file will always return ENXIO. To avoid this,
> change the scsi_sdev_attr_is_visible function to hide wwid sysfs file
> when the devices does not support VPD.

Not a big fan of attribute files that come and go.

Why not just return an empty string? Hannes?

--
Martin K. Petersen Oracle Linux Engineering