Re: [PATCH 2/3] ARM: ixp4xx: mark ixp4xx_irq_setup as __init

From: Olof Johansson
Date: Tue Jun 18 2019 - 07:05:06 EST


On Mon, Jun 17, 2019 at 1:25 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> Kbuild complains about ixp4xx_irq_setup not being __init
> itself in some configurations:
>
> WARNING: vmlinux.o(.text+0x85bae4): Section mismatch in reference from the function ixp4xx_irq_setup() to the function .init.text:set_handle_irq()
> The function ixp4xx_irq_setup() references
> the function __init set_handle_irq().
> This is often because ixp4xx_irq_setup lacks a __init
> annotation or the annotation of set_handle_irq is wrong.
>
> I suspect it normally gets inlined, so we get no such warning,
> but clang makes this obvious when the function is left out
> of line.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied to arm/fixes. Thanks!


-Olof