Re: [PATCH] serial: sh-sci: fix uninitialized variable warning

[Greg Kroah-Hartman]

On Thu, Jun 13, 2019 at 03:08:24PM -0300, Charles wrote:
> Avoid following compiler warning on uninitialized variable
> 
> In file included from ./include/linux/rwsem.h:16:0,
>                  from ./include/linux/notifier.h:15,
>                  from ./include/linux/clk.h:17,
>                  from drivers/tty/serial/sh-sci.c:24:
> drivers/tty/serial/sh-sci.c: In function âsci_dma_rx_submitâ:
> ./include/linux/spinlock.h:288:3: warning: âflagsâ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>    _raw_spin_unlock_irqrestore(lock, flags); \
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/tty/serial/sh-sci.c:1353:16: note: âflagsâ was declared here
>   unsigned long flags;
>                 ^~~~~

What version of gcc is doing this?  It should be smarter than that,
perhaps you should just upgrade.

thanks,

greg k-h