Re: [PATCH] proc/sysctl: make firmware loader table conditional

From: Arnd Bergmann
Date: Mon Jun 17 2019 - 11:05:25 EST


On Mon, Jun 17, 2019 at 4:42 PM Matteo Croce <mcroce@xxxxxxxxxx> wrote:
> > drivers/base/firmware_loader/fallback_table.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/base/firmware_loader/fallback_table.c b/drivers/base/firmware_loader/fallback_table.c
> > index 58d4a1263480..ba9d30b28edc 100644
> > --- a/drivers/base/firmware_loader/fallback_table.c
> > +++ b/drivers/base/firmware_loader/fallback_table.c
> > @@ -23,6 +23,7 @@ struct firmware_fallback_config fw_fallback_config = {
> > };
> > EXPORT_SYMBOL_GPL(fw_fallback_config);
> >
> > +#ifdef CONFIG_SYSCTL
> > struct ctl_table firmware_config_table[] = {
> > {
> > .procname = "force_sysfs_fallback",
> > @@ -45,3 +46,4 @@ struct ctl_table firmware_config_table[] = {
> > { }
> > };
> > EXPORT_SYMBOL_GPL(firmware_config_table);
> > +#endif
> > --
> > 2.20.0
> >
>
> Hi Arnd,
>
> I think I've posted a similar patch before, I don't know if it's
> already in linux-next:
>
> https://lore.kernel.org/linux-next/20190531012649.31797-1-mcroce@xxxxxxxxxx/
>

Indeed, that is almost the same patch. Not sure what happened.

As Stephen replied to your patch, he had picked it up originally.
Maybe it got lost in a rebase since then.

Arnd