Re: [PATCH 14/14] docs: sphinx/kernel_abi.py: fix UTF-8 support

From: Mauro Carvalho Chehab
Date: Mon Jun 17 2019 - 05:22:00 EST


Em Sun, 16 Jun 2019 17:43:50 +0200
Markus Heiser <markus.heiser@xxxxxxxxxxx> escreveu:

> Am 14.06.19 um 18:25 schrieb Mauro Carvalho Chehab:
> > Em Fri, 14 Jun 2019 18:18:37 +0200
> > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> escreveu:
> >
> >> On Thu, Jun 13, 2019 at 11:04:20PM -0300, Mauro Carvalho Chehab wrote:
> >>> The parser breaks with UTF-8 characters with Sphinx 1.4.
> >>>
> >>> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>
> >>> ---
> >>> Documentation/sphinx/kernel_abi.py | 10 ++++++----
> >>> 1 file changed, 6 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/Documentation/sphinx/kernel_abi.py b/Documentation/sphinx/kernel_abi.py
> >>> index 7fa7806532dc..460cee48a245 100644
> >>> --- a/Documentation/sphinx/kernel_abi.py
> >>> +++ b/Documentation/sphinx/kernel_abi.py
> >>> @@ -1,4 +1,5 @@
> >>> -# -*- coding: utf-8; mode: python -*-
> >>> +# coding=utf-8
> >>> +#
> >>
> >> Is this an emacs vs. vim fight?
> >
> > No. This is a python-specific thing:
> >
> > https://www.python.org/dev/peps/pep-0263/
>
> No need to change, the emacs notation is also OK, see your link
>
> """or (using formats recognized by popular editors):"""
>
> https://www.python.org/dev/peps/pep-0263/#defining-the-encoding
>
> I prefer emacs notation, this is also evaluated by many other editors / tools.

The usage of emacs notation is something that we don't like at the
Linux Kernel. With ~4K developers per release, if we add tags to
every single editor people use, it would be really messy, as one
developer would be adding a tag and the next one replacing it by its
some other favorite editor's tag.

There's even an item at Documentation/process/coding-style.rst
due to that (item 9).

Thanks,
Mauro