Re: [PATCH 1/5] glibc: Perform rseq(2) registration at C startup and thread creation (v10)

From: Florian Weimer
Date: Fri Jun 14 2019 - 09:47:26 EST


* Mathieu Desnoyers:

> + /* Publicize rseq registration ownership. This must be performed
> + after rtld re-relocation, before invoking constructors of
> + preloaded libraries. */
> + rseq_init ();

Please add a comment that IFUNC resolvers do not see the initialized
value. I think this is okay because we currently do not support access
to extern variables in IFUNC resolvers.

> /* Do any necessary cleanups for the startup OS interface code.
> We do these now so that no calls are made after rtld re-relocation
> which might be resolved to different functions than we expect.
>
> It works fine now!

Great.

Thanks,
Florian