Re: [PATCH 05/34] leds: leds-tca6507: simplify getting the adapter of a client

From: Simon Horman
Date: Thu Jun 13 2019 - 11:48:19 EST


On Sat, Jun 08, 2019 at 12:55:44PM +0200, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

> ---
>
> Please apply to your subsystem tree.
>
> drivers/leds/leds-tca6507.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
> index c59035e157d1..58be20cae183 100644
> --- a/drivers/leds/leds-tca6507.c
> +++ b/drivers/leds/leds-tca6507.c
> @@ -758,7 +758,7 @@ static int tca6507_probe(struct i2c_client *client,
> int err;
> int i = 0;
>
> - adapter = to_i2c_adapter(client->dev.parent);
> + adapter = client->adapter;
> pdata = dev_get_platdata(&client->dev);
>
> if (!i2c_check_functionality(adapter, I2C_FUNC_I2C))
> --
> 2.19.1
>