Re: [PATCH] bpf: selftests: Fix warning in flow_dissector

From: Stanislav Fomichev
Date: Thu Jun 13 2019 - 11:46:37 EST


On 06/13, Arthur Fabre wrote:
> Building the userspace part of the flow_dissector resulted in:
>
> prog_tests/flow_dissector.c: In function âtx_tapâ:
> prog_tests/flow_dissector.c:176:9: warning: implicit declaration
> of function âwritevâ; did you mean âwriteâ? [-Wimplicit-function-declaration]
> return writev(fd, iov, ARRAY_SIZE(iov));
> ^~~~~~
> write
>
> Include <sys/uio.h> to fix this.
Wasn't it fixed already?

See
https://lore.kernel.org/netdev/20190528190218.GA6950@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

> Signed-off-by: Arthur Fabre <afabre@xxxxxxxxxxxxxx>
> ---
> tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> index fbd1d88a6095..c938283ac232 100644
> --- a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> +++ b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> @@ -3,6 +3,7 @@
> #include <error.h>
> #include <linux/if.h>
> #include <linux/if_tun.h>
> +#include <sys/uio.h>
>
> #define CHECK_FLOW_KEYS(desc, got, expected) \
> CHECK_ATTR(memcmp(&got, &expected, sizeof(got)) != 0, \
> --
> 2.20.1
>