Re: [PATCH-next 19/20] gpio: gpio-omap: irq_startup() must not return error codes

From: Linus Walleij
Date: Wed Jun 12 2019 - 05:03:50 EST


On Mon, Jun 10, 2019 at 7:13 PM Grygorii Strashko
<grygorii.strashko@xxxxxx> wrote:

> From: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
>
> The irq_startup() method returns an unsigned int, but in __irq_startup()
> it is assigned to an int. However, nothing checks for errors, so any
> error that is returned is ignored.
>
> Remove the check for GPIO-input mode and the error return.
>
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>

Patch applied.

Yours,
Linus Walleij