Re: [PATCH v2 0/4] Additional fixes on Talitos driver

[Christophe Leroy]

Le 11/06/2019 Ã 18:30, Horia Geanta a ÃcritÂ:
> On 6/11/2019 6:40 PM, Christophe Leroy wrote:
> > Le 11/06/2019 Ã 17:37, Horia Geanta a ÃcritÂ:
> > > On 6/11/2019 5:39 PM, Christophe Leroy wrote:
> > > > This series is the last set of fixes for the Talitos driver.
> > > >
> > > > We now get a fully clean boot on both SEC1 (SEC1.2 on mpc885) and
> > > > SEC2 (SEC2.2 on mpc8321E) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS:
> > > I am getting below failures on a sec 3.3.2 (p1020rdb) for hmac(sha384) and
> > > hmac(sha512):
> >
> > Is that new with this series or did you already have it before ?
> Looks like this happens with or without this series.

Found the issue, that's in 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b8fbdc2bc4e71b62646031d5df5f08aafe15d5ad

CONFIG_CRYPTO_DEV_TALITOS_SEC2 should be CONFIG_CRYPTO_DEV_TALITOS2 instead.

Just sent a patch to fix it.

Thanks
Christophe

> I haven't checked the state of this driver for quite some time.
> Since I've noticed increased activity, I thought it would be worth
> actually testing the changes.
>
> Are changes in patch 2/4 ("crypto: talitos - fix hash on SEC1.")
> strictly for sec 1.x or they affect all revisions?
>
> > What do you mean by "fuzz testing" enabled ? Is that
> > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS or something else ?
> Yes, it's this config symbol.
>
> Horia