Re: [PATCH 07/15] x86: Add int3_emulate_call() selftest

[Peter Zijlstra]

On Mon, Jun 10, 2019 at 09:57:58AM -0700, Andy Lutomirski wrote:
> On Mon, Jun 10, 2019 at 9:53 AM Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> >
> > On Wed, Jun 05, 2019 at 03:08:00PM +0200, Peter Zijlstra wrote:
> > > Given that the entry_*.S changes for this functionality are somewhat
> > > tricky, make sure the paths are tested every boot, instead of on the
> > > rare occasion when we trip an INT3 while rewriting text.
> > >
> > > Requested-by: Andy Lutomirski <luto@xxxxxxxxxx>
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> >
> > Reviewed-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> >
> 
> Looks good to me, too,

I'll translate that into an Acked-by from you, if you don't mind :-)

> except that I seriously hate die notifiers that
> return NOTIFY_STOP, and I eventually want to remove support for them.
> This can wait, though.

Yes, I share your hatred for notifiers in general. But since they are
still here and I do think it is a waste to have an unconditional
function call in do_int3() just for this, I figured I'd use them.