Re: [PATCH 8/8] habanalabs: enable 64-bit DMA mask in POWER9

[Greg KH]

On Tue, Jun 11, 2019 at 08:50:45AM +0300, Oded Gabbay wrote:
> --- a/drivers/misc/habanalabs/habanalabs_drv.c
> +++ b/drivers/misc/habanalabs/habanalabs_drv.c
> @@ -28,6 +28,7 @@ static DEFINE_MUTEX(hl_devs_idr_lock);
>  
>  static int timeout_locked = 5;
>  static int reset_on_lockup = 1;
> +static int power9_64bit_dma_enable;
>  
>  module_param(timeout_locked, int, 0444);
>  MODULE_PARM_DESC(timeout_locked,
> @@ -37,6 +38,10 @@ module_param(reset_on_lockup, int, 0444);
>  MODULE_PARM_DESC(reset_on_lockup,
>  	"Do device reset on lockup (0 = no, 1 = yes, default yes)");
>  
> +module_param(power9_64bit_dma_enable, int, 0444);
> +MODULE_PARM_DESC(power9_64bit_dma_enable,
> +	"Enable 64-bit DMA mask. Should be set only in POWER9 machine (0 = no, 1 = yes, default no)");
> +
>  #define PCI_VENDOR_ID_HABANALABS	0x1da3
>  
>  #define PCI_IDS_GOYA			0x0001


This is not the 1990's, please do not use module parameters.  Yeah, you
have a bunch of them already, but do not add additional ones that can be
easily determined at runtime, like this one.

thanks,

greg k-h