Re: [PATCH 2/2] serial: uartps: Use the same dynamin major number for all ports

From: Greg KH
Date: Mon Jun 10 2019 - 13:17:32 EST


On Mon, Jun 10, 2019 at 10:44:56AM +0200, Michal Simek wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
>
> Let kernel to find out major number dynamically for the first device and
> then reuse it for other instances.
> This fixes the issue that each uart is registered with a
> different major number.
>
> After the patch:
> crw------- 1 root root 253, 0 Jun 10 08:31 /dev/ttyPS0
> crw--w---- 1 root root 253, 1 Jan 1 1970 /dev/ttyPS1
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> ---
>
> drivers/tty/serial/xilinx_uartps.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)

Does not apply without patch 1/2, so dropping it from my queue.

Which is ALWAYS a good reason why you should submit bug fixes or other
things before code cleanup patches.

thanks,

greg k-h