Re: [PATCH 2/2] arm64: dts: rockchip: Define values for the IPA governor for rock960

[Daniel Lezcano]

On 08/06/2019 00:18, Linus Walleij wrote:
> On Tue, Jun 4, 2019 at 6:58 PM Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:
> 
>> The intelligent power allocator PID coefficient to be set in sysfs
>> are:
>>
>>     k_d: 0
>>     k_po: 79
>>     k_i: 10
>>     k_pu: 50
> 
> With all the other interesting parametrization in the device tree
> I kind of wonder why the PID regulator constants defaults are
> not set up from device tree?
> 
> Any specific reason?

None I'm aware of. I guess these constants are considered as tweak
values and not hardware related.

> To me it seems like the kind of stuff userpace will invariably just
> get wrong or forget about (somebody just runs a different
> distribution without the extra magic to set sysfs right) unless
> we supply good defaults.

I agree.

-- 
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog