Re: [PATCH] MIPS: lb60: Fix pin mappings

From: Paul Cercueil
Date: Sat Jun 08 2019 - 06:18:57 EST




Le sam. 8 juin 2019 à 0:10, Linus Walleij <linus.walleij@xxxxxxxxxx> a écrit :
On Tue, Jun 4, 2019 at 6:34 PM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote:

The pin mappings introduced in commit 636f8ba67fb6
("MIPS: JZ4740: Qi LB60: Add pinctrl configuration for several drivers")
are completely wrong. The pinctrl driver name is incorrect, and the
function and group fields are swapped.

Fixes: 636f8ba67fb6 ("MIPS: JZ4740: Qi LB60: Add pinctrl configuration for several drivers")
Cc: <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Such things happen. Are you planning to phase all the board files over
to use devicetree eventually?

Yes, that's definitely what's planned; right now the blockers are
patchsets [1] and [2]. [1] is ignored by everybody because there's no
maintainer for drivers/memory/. [2] is a year-long effort that still
doesn't show me the light at the end of the tunnel.

[1] https://lkml.org/lkml/2019/6/4/743
[2] https://lkml.org/lkml/2019/5/21/679

Cheers
-Paul