RE: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl

From: Dragan Cvetic
Date: Fri Jun 07 2019 - 07:02:50 EST


> On Sat, May 25, 2019 at 12:37:17PM +0100, Dragan Cvetic wrote:
> > +static int xsdfec_dev_open(struct inode *iptr, struct file *fptr)
> > +{
> > + return 0;
> > +}
> > +
> > +static int xsdfec_dev_release(struct inode *iptr, struct file *fptr)
> > +{
> > + return 0;
> > +}
>
> empty open/close functions are never needed, just drop them.
>

open() is needed to allocate file descriptor eg.
fd = open(dev_name, O_RDWR);

Please, advise if you have some other idea in mind

Thanks
Dragan