RE: [PATCH V3 3/4] clk: imx: Add support for i.MX8MN clock driver

From: Anson Huang
Date: Thu Jun 06 2019 - 20:54:44 EST


Hi, Stephen

> -----Original Message-----
> From: Stephen Boyd <sboyd@xxxxxxxxxx>
> Sent: Friday, June 7, 2019 12:26 AM
> To: Anson Huang <anson.huang@xxxxxxx>; Abel Vesa
> <abel.vesa@xxxxxxx>; Aisheng Dong <aisheng.dong@xxxxxxx>;
> bjorn.andersson@xxxxxxxxxx; catalin.marinas@xxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; dinguyen@xxxxxxxxxx;
> enric.balletbo@xxxxxxxxxxxxx; festevam@xxxxxxxxx;
> horms+renesas@xxxxxxxxxxxx; jagan@xxxxxxxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; l.stach@xxxxxxxxxxxxxx; Leonard Crestez
> <leonard.crestez@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> clk@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; mark.rutland@xxxxxxx;
> maxime.ripard@xxxxxxxxxxx; mturquette@xxxxxxxxxxxx; olof@xxxxxxxxx;
> Jacky Bai <ping.bai@xxxxxxx>; robh+dt@xxxxxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx; will.deacon@xxxxxxx
> Cc: dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH V3 3/4] clk: imx: Add support for i.MX8MN clock driver
>
> Quoting Anson.Huang@xxxxxxx (2019-06-03 18:59:27)
> > From: Anson Huang <Anson.Huang@xxxxxxx>
> >
> > This patch adds i.MX8MN clock driver support.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > ---
> > Changes since V2:
> > - use platform driver model for this clock driver;
>
> Can you also use platform device APIs like platform_*(),
> devm_ioremap_resource() and devmified clk registration?

I will use devm_platform_ioremap_resource() instead of ioremap(),
and can you be more specific about devmified clk registration?

Thanks,
Anson