Re: [PATCH v2] drivers: scsi: remove unnecessary #ifdef MODULE

From: James Bottomley
Date: Thu Jun 06 2019 - 20:45:54 EST


On Thu, 2019-06-06 at 17:04 +0200, Enrico Weigelt, metux IT consult
wrote:
> From: Enrico Weigelt <info@xxxxxxxxx>
>
> The MODULE_DEVICE_TABLE() macro already checks for MODULE defined,
> so the extra check here is not necessary.
>
> Changes v2:
> * make dptids const to fix warning on unused variable

I don't think this works; in my version of gcc, const does not defeat
the unused variable warning if I try with a test programme:

jejb@jarvis:~> gcc -Wunused-variable -c test1.c
test1.c:3:18: warning: âiâ defined but not used [-Wunused-cons
t-variable=]
static const int i[] = { 1, 2, 3};

James